Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tdelabro)

Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tdelabro)

scripts/cairo_fmt.sh line 3 at r2 (raw file):

#!/bin/bash

cargo run --bin cairo-format --features="binary" -- --recursive "$@"

Do I need to specify this when I run? Why is that, I thought defining in the toml is enough.
I'd really like to avoid this.

Personally, I believe extracting binaries to a separate crate is a way to go upfront here. I suspect this play with features will bring issues to compiler crates users :/

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tdelabro)

@tdelabro Can you try to separate the binaries into different crate then?
Remember to add the new crate to the ci yml file.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tdelabro)

Reviewed 29 of 29 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tdelabro)

Reviewed 2 of 9 files at r1, 2 of 8 files at r2, 27 of 29 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tdelabro)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tdelabro)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tdelabro)

crates/cairo-lang-language-server/src/lib.rs line 72 at r3 (raw file):

pub async fn serve_language_service() {
    init_logging(log::LevelFilter::Warn);

@maciektr please take a look at this, I think we will have to adapt Scarb's LS to also include logging, perhaps via tracing which we use there?